[Bug fix] Rule based Auto tagging update rule api #18488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for https://github.com/opensearch-project/OpenSearch/pull/17797/files
Problem:
When trying to update a rule by just changing its description, the system incorrectly throws a "duplicate rule" error, even though no duplicate rule is created.
When the rule in any api has the same rule id as an existing rule, it means either we are updating an existing rule or we already have the exact same rule in the system under the same doc id (because id is generated based on rule content), in either case, we are not creating duplicate rules so the system shouldn't throw error.
This PR addressed the above issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.