fix the bug of Access denied error when rolling log files #18597
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❕ Gradle check result for cf30aec: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.19 #18597 +/- ##
============================================
+ Coverage 71.83% 72.00% +0.17%
- Complexity 65910 65960 +50
============================================
Files 5341 5341
Lines 307194 307194
Branches 44835 44835
============================================
+ Hits 220664 221192 +528
+ Misses 68065 67537 -528
Partials 18465 18465 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liuyonghengheng
force-pushed
the
2.19_dev
branch
4 times, most recently
from
d0d08d0 to
57c6caf
Compare
Signed-off-by: Yongheng Liu <[email protected]>
liuyonghengheng
force-pushed
the
2.19_dev
branch
from
57c6caf to
4c89362
Compare
|
❕ Gradle check result for 4c89362: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logs rolling triggered AccessControlException, and the log files access permission are not
rw-r-----. More and more users get this error, although it is not a fatal issue, it is a issue that we will encounter when out-of-the-box,so i think we should fix it.Related Issues
Resolves #18594 #9609
Test
The test Result is expected behavior
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.