Skip to content

[refs #18606] Use the same thread for a mock invocation #18607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mishail
Copy link
Contributor

@Mishail Mishail commented Jun 25, 2025

Description

Changed TransportGetRuleActionTests.testExecute to use SameThreadExecutorService to avoid race conditions

Related Issues

Resolves #18606

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Mishail Mishail requested a review from a team as a code owner June 25, 2025 03:42
@github-actions github-actions bot added bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. labels Jun 25, 2025
@Mishail
Copy link
Contributor Author

Mishail commented Jun 25, 2025

cc @ruai0511

Copy link
Contributor

❌ Gradle check result for e7586d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Mishail
Copy link
Contributor Author

Mishail commented Jun 25, 2025

❌ Gradle check result for e7586d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test failure: #14551

Copy link
Contributor

❌ Gradle check result for e7586d5:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Mishail
Copy link
Contributor Author

Mishail commented Jun 25, 2025

❌ Gradle check result for e7586d5:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Hm, I can't find the jenkins job for this check. Was it triggered at all?

@Mishail Mishail closed this Jun 25, 2025
@Mishail Mishail reopened this Jun 25, 2025
Copy link
Contributor

✅ Gradle check result for e7586d5: SUCCESS

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (d9661c0) to head (e7586d5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18607      +/-   ##
============================================
+ Coverage     72.55%   72.64%   +0.09%     
- Complexity    68185    68220      +35     
============================================
  Files          5555     5555              
  Lines        313857   313857              
  Branches      45522    45522              
============================================
+ Hits         227707   228013     +306     
+ Misses        67616    67335     -281     
+ Partials      18534    18509      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Race condition in TransportGetRuleActionTests.testExecute
2 participants