Add specs for alert and finding endpoints of security_analytics plugin #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineSauzeau
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
AntoineSauzeau
force-pushed
the
add_security_analytics_specs
branch
from
6574870 to
308ea8e
Compare
|
Please add tests? |
AntoineSauzeau
force-pushed
the
add_security_analytics_specs
branch
from
308ea8e to
1cf4919
Compare
|
Oups sorry. |
Changes AnalysisCommit SHA: 3b9ab09 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/15686071192/artifacts/3349535783 API Coverage
|
Xtansia
requested changes
Jun 6, 2025
Xtansia
requested changes
Jun 6, 2025
|
Thank you for the review. |
Xtansia
requested changes
Jun 9, 2025
There was a problem hiding this comment.
Thanks for making those changes @AntoineSauzeau, still just a few things to address.
Please also rebase your branch onto the latest main commit.
AntoineSauzeau
force-pushed
the
add_security_analytics_specs
branch
2 times, most recently
from
2fde2eb to
04c4c9f
Compare
|
Done. |
Spec Test Coverage Analysis
|
Signed-off-by: Antoine Sauzeau <[email protected]>
Signed-off-by: Antoine Sauzeau <[email protected]>
Signed-off-by: Antoine Sauzeau <[email protected]>
Signed-off-by: Antoine Sauzeau <[email protected]>
Signed-off-by: Antoine Sauzeau <[email protected]>
Signed-off-by: Antoine Sauzeau <[email protected]>
AntoineSauzeau
force-pushed
the
add_security_analytics_specs
branch
from
04c4c9f to
3b9ab09
Compare
|
Do you see any changes needed before considering merging ? @Xtansia |
Xtansia
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add specs for the 3 following endpoints :
I intend to add all the other security analytics endpoints but I'd rather start with a small piece since this is the first time that I'm contributing to this repo.
Since there's no endpoint to directly create findings and alerts, I'm supposed to do it by hand with some
POST <index>/_create/<_id>to test properly these endpoints then ?Issues Resolved
Related to #239.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.