Skip to content

updating default values for shard_stores parameters #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AntonEliatra
Copy link
Contributor

Description

Updating default values for shard_stores parameters

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Changes Analysis

Commit SHA: 35af0fc
Comparing To SHA: 2990ed7

API Changes

Summary

└─┬Paths
  ├─┬/{index}/_shard_stores
  │ └─┬GET
  │   ├─┬Parameters
  │   │ └─┬Schema
  │   │   └──[➕] default (23093:18)❌ 
  │   ├─┬Parameters
  │   │ └─┬Schema
  │   │   └──[➕] default (23075:18)❌ 
  │   └─┬Parameters
  │     └─┬Schema
  │       └──[➕] default (23100:18)❌ 
  └─┬/_shard_stores
    └─┬GET
      ├─┬Parameters
      │ └─┬Schema
      │   └──[➕] default (23075:18)❌ 
      ├─┬Parameters
      │ └─┬Schema
      │   └──[➕] default (23093:18)❌ 
      └─┬Parameters
        └─┬Schema
          └──[➕] default (23100:18)❌ 

Document Element Total Changes Breaking Changes
paths 6 6
  • BREAKING Changes: 6 out of 6
  • Additions: 6
  • Breaking Additions: 6

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/15752758969/artifacts/3361233450

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 91 91 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
644 642 (99.69 %)

@AntonEliatra
Copy link
Contributor Author

@Xtansia Would you be able to assist on this? I'm seeing breaking changes, but the relevant tests pass locally, Can you tell me if there is anything else that I should update on this?

@Xtansia
Copy link
Collaborator

Xtansia commented Jun 18, 2025

@AntonEliatra The only failing check now is for a missing changelog entry

Signed-off-by: Anton Rubin <[email protected]>
@AntonEliatra
Copy link
Contributor Author

@Xtansia Thank you for the review, wasn't sure if the "breaking changes" were expected. I've updated the change log now.

@dblock dblock merged commit 8d5d843 into opensearch-project:main Jun 21, 2025
32 checks passed
@AntonEliatra AntonEliatra deleted the updating-default-values-for-shard_stores branch June 23, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants