Skip to content

add persistentImages #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2024
Merged

add persistentImages #281

merged 4 commits into from
May 15, 2024

Conversation

T0MASD
Copy link
Contributor

@T0MASD T0MASD commented May 14, 2024

Add persistentImages feature which perserves local images between ocm-container sessions

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@openshift-ci openshift-ci bot requested review from AlexVulaj and rendhalver May 14, 2024 11:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@T0MASD T0MASD force-pushed the presistent_images branch from 1a06e98 to 6af1515 Compare May 14, 2024 14:56
@T0MASD T0MASD changed the title WIP: add persistentImages add persistentImages May 14, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@T0MASD
Copy link
Contributor Author

T0MASD commented May 14, 2024

/unhold

@T0MASD T0MASD force-pushed the presistent_images branch from 6af1515 to e2fe4f0 Compare May 14, 2024 15:12
@T0MASD
Copy link
Contributor Author

T0MASD commented May 14, 2024

/hold for fix to left over containers

$ podman ps -aq
bd2a8b53fd5c
e8bfe9d90987

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@T0MASD
Copy link
Contributor Author

T0MASD commented May 14, 2024 •
edited
Loading

it's not possible to mount just /var/lib/containers/storage/overlay/ in addition verified 2 container sessions happily share the mount

@T0MASD
Copy link
Contributor Author

T0MASD commented May 14, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
clcollins
clcollins suggested changes May 14, 2024
View reviewed changes
Copy link
Member

@clcollins clcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Other than the ocm client comment and a suggestion for a debug log line, I'm good with this.

I see you have this held related to container cleanup? What is the issue you're seeing there?

@T0MASD T0MASD force-pushed the presistent_images branch from e2fe4f0 to 4d5fb71 Compare May 14, 2024 18:41
@T0MASD
Copy link
Contributor Author

T0MASD commented May 14, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 14, 2024
@T0MASD T0MASD force-pushed the presistent_images branch from 191364e to 6aaba1c Compare May 14, 2024 20:12
@T0MASD T0MASD force-pushed the presistent_images branch from 6aaba1c to 452a6f7 Compare May 14, 2024 20:14
@T0MASD
Copy link
Contributor Author

T0MASD commented May 15, 2024

@clcollins I've addressed the issue I have brought up earlier in openshift/backplane-cli#419
this change is good to go!

@clcollins
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, T0MASD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9f964ec into openshift:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clcollins clcollins clcollins requested changes

@AlexVulaj AlexVulaj Awaiting requested review from AlexVulaj

@rendhalver rendhalver Awaiting requested review from rendhalver

Assignees

@clcollins clcollins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T0MASD @clcollins