feat(startup): remove unused variable #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the macos 'ssh-agent' works without issues, there is no need for runnig ssh-agent before the command
drewandersonnz
added a commit
to drewandersonnz/ocm-container
that referenced
this pull request
Nov 23, 2020
…-client auto-detect latest openshift-client-linux-4.x.y.tar.gz
|
On linux environments this variable was empty, therefore had no effect. Meaning, +1 to merge based on a Fedora linux execution environment. @iamkirkbater can you confirm it still works as planned on macos? Can you still use your ssh-agent/keyring/whatever to connect outbound with this change? |
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the macos 'ssh-agent' works without issues,
there is no need for runnig ssh-agent before the command