Skip to content

CORENET-5975: Dockerfile: Unpin OVS and consume the latest from FDP. #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igsilya
Copy link
Contributor

@igsilya igsilya commented Apr 29, 2025

OVN-Kubernetes is always lagging behind on the version of OVS it pins. This is causing a lot of trouble with keeping up with bug fixes and especially CVE fixes on older branches, resulting in scanners constantly flagging this image with poor security grades.

OVS package inside the container is responsible for the following:

  1. Command line utilities to talk with OVS from the host.
  2. ovsdb-server processes serving OVN databases.
  3. ovs-monitor-ipsec script for managing ipsec configuration on OVN tunnels.

These tools/programs are not changing that much between patch releases, and bug fix releases in FDP are going through a lot of testing before becoming available in the repo. So, benefits of timely delivery of bug and CVE fixes significantly outweighs the small risks that automatic consumption of new builds incurs. Main OVS is working on the host and follows FDP for a very long time now, and it's also better to keep the minor versions between host and container in sync, just to decrease the amount of variables in the system.

OVN-Kubernetes is always lagging behind on the version of OVS it pins.
This is causing a lot of trouble with keeping up with bug fixes and
especially CVE fixes on older branches, resulting in scanners constantly
flagging this image with poor security grades.

OVS package inside the container is responsible for the following:

  1. Command line utilities to talk with OVS from the host.
  2. ovsdb-server processes serving OVN databases.
  3. ovs-monitor-ipsec script for managing ipsec configuration on
     OVN tunnels.

These tools/programs are not changing that much between patch releases,
and bug fix releases in FDP are going through a lot of testing before
becoming available in the repo.  So, benefits of timely delivery of bug
and CVE fixes significantly outweighs the small risks that automatic
consumption of new builds incurs.  Main OVS is working on the host and
follows FDP for a very long time now, and it's also better to keep
the minor versions between host and container in sync, just to decrease
the amount of variables in the system.

Signed-off-by: Ilya Maximets <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2025
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: igsilya
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@igsilya
Copy link
Contributor Author

igsilya commented Apr 29, 2025

/test all

@igsilya
Copy link
Contributor Author

igsilya commented Apr 30, 2025

/retest

@igsilya igsilya changed the title Dockerfile: Unpin OVS and consume the latest from FDP. CORENET-5975: Dockerfile: Unpin OVS and consume the latest from FDP. Apr 30, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 30, 2025

@igsilya: This pull request references CORENET-5975 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

OVN-Kubernetes is always lagging behind on the version of OVS it pins. This is causing a lot of trouble with keeping up with bug fixes and especially CVE fixes on older branches, resulting in scanners constantly flagging this image with poor security grades.

OVS package inside the container is responsible for the following:

  1. Command line utilities to talk with OVS from the host.
  2. ovsdb-server processes serving OVN databases.
  3. ovs-monitor-ipsec script for managing ipsec configuration on OVN tunnels.

These tools/programs are not changing that much between patch releases, and bug fix releases in FDP are going through a lot of testing before becoming available in the repo. So, benefits of timely delivery of bug and CVE fixes significantly outweighs the small risks that automatic consumption of new builds incurs. Main OVS is working on the host and follows FDP for a very long time now, and it's also better to keep the minor versions between host and container in sync, just to decrease the amount of variables in the system.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@igsilya igsilya marked this pull request as ready for review April 30, 2025 10:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2025
@openshift-ci openshift-ci bot requested review from jcaamano and trozet April 30, 2025 10:12
@igsilya
Copy link
Contributor Author

igsilya commented Apr 30, 2025

Cc: @tssurya

@igsilya
Copy link
Contributor Author

igsilya commented Apr 30, 2025

/test e2e-aws-ovn-fdp-qe

@igsilya igsilya changed the base branch from release-4.19 to master April 30, 2025 12:04
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 30, 2025

@igsilya: This pull request references CORENET-5975 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

OVN-Kubernetes is always lagging behind on the version of OVS it pins. This is causing a lot of trouble with keeping up with bug fixes and especially CVE fixes on older branches, resulting in scanners constantly flagging this image with poor security grades.

OVS package inside the container is responsible for the following:

  1. Command line utilities to talk with OVS from the host.
  2. ovsdb-server processes serving OVN databases.
  3. ovs-monitor-ipsec script for managing ipsec configuration on OVN tunnels.

These tools/programs are not changing that much between patch releases, and bug fix releases in FDP are going through a lot of testing before becoming available in the repo. So, benefits of timely delivery of bug and CVE fixes significantly outweighs the small risks that automatic consumption of new builds incurs. Main OVS is working on the host and follows FDP for a very long time now, and it's also better to keep the minor versions between host and container in sync, just to decrease the amount of variables in the system.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@igsilya
Copy link
Contributor Author

igsilya commented Apr 30, 2025

/retest

@igsilya
Copy link
Contributor Author

igsilya commented Apr 30, 2025

Failures do not seem related.
/retest

@igsilya
Copy link
Contributor Author

igsilya commented May 2, 2025

/retest

@igsilya
Copy link
Contributor Author

igsilya commented May 2, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented May 2, 2025

@igsilya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 4fb27fe link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-upgrade-local-gateway 4fb27fe link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-aws-ovn-clusternetwork-cidr-expansion 4fb27fe link false /test e2e-aws-ovn-clusternetwork-cidr-expansion
ci/prow/e2e-aws-ovn-windows 4fb27fe link true /test e2e-aws-ovn-windows
ci/prow/okd-scos-e2e-aws-ovn 4fb27fe link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift-kubevirt 4fb27fe link false /test e2e-aws-ovn-hypershift-kubevirt
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview 4fb27fe link false /test e2e-aws-ovn-hypershift-conformance-techpreview
ci/prow/security 4fb27fe link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants