Provide better error for non-supported private keys #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoltanFridrich
force-pushed
the
zfridric_devel2
branch
3 times, most recently
from
a3357a0 to
94b7a7d
Compare
Signed-off-by: Zoltan Fridrich <[email protected]>
ZoltanFridrich
force-pushed
the
zfridric_devel2
branch
from
94b7a7d to
f6180ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I try to use a PuTTY key (".ppk" format) ssh prints the following error:
after some analysis it seems that when using unsupported private key the following call to
PEM_read_bio_PrivateKeyfails:https://github.com/openssh/openssh-portable/blob/master/sshkey.c#L3544
returned error is of type
ERR_GET_LIB(pem_err) = ERR_LIB_OSSL_DECODER.In
translate_libcrypto_error()function this type of error is unrecognized and will default toSSH_ERR_LIBCRYPTO_ERROR.This patch changes the error output to: