-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Avoid unnecessary transform operations during prefetch #17013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JkshirsagarMaxlinear I took a liberty to edit the PR title. Also I suspect that too long first line of the commit message may not pass the style check. It is recommended to have the first line to be shorter to be more meaningful in one line commit lists. Also the commit message is somewhat confusing, since this change is not specific to compression. It in general saves on buffer allocation and filling, that cost something even if the block is not compressed. Please amend and force-push to make it nice. Please read the documents referenced in the PR checklist if not yet. |
f270858
to
b6cdc85
Compare
@amotin Thank you. I have updated the commit and pull request. |
Thank you @amotin. It says that I am not authorized to merge the pull request. |
@JkshirsagarMaxlinear Only few people can merge here. I'll do it after CI tests pass. |
@JkshirsagarMaxlinear But I see you added here unneeded merge commit. Please clean it up with rebase. There should be only one commit. |
This change will prevent prefetch to perform unnecessary transform operations on ARC buffer. Signed-off-by: Jaydeep Kshirsagar <[email protected]>
52f20d2
to
d3bafb1
Compare
Hi @amotin |
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary ARC buffer fill when reading from disk. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Jaydeep Kshirsagar <[email protected]> Co-authored-by: Alexander Motin <[email protected]> Closes openzfs#17013
This change will prevent prefetch to perform unnecessary transform operations on ARC buffer.
Motivation and Context
In current ZFS, the read performance with prefetch enabled was getting affected because of the extra and unnecessary operations happening on ARC buffer. While the flag to avoid the ARC buffer was set in prefetch path, it was not getting assigned when actual zio is getting data from Disk to ARC.
This change will reduce the CPU utilization and boost the performance.
Closes #17008
Description
This change is mainly focused on utilizing the existing flag to avoid the unnecessary operations (buffer allocation and transform operations) in prefetch.
How Has This Been Tested?
This change was tested on following system:
Types of changes
Checklist:
Signed-off-by
.