Skip to content

runners: Fix zfs-release RPM creation #17173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

runners: Fix zfs-release RPM creation #17173

merged 1 commit into from
Mar 26, 2025

Conversation

tonyhutter
Copy link
Contributor

Motivation and Context

Let zfs-qemu-packages-packages workflow correctly build zfs-release RPMs.

Description

The zfs-qemu-packages workflow was incorrectly copying the built zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs. This meant that the RPMs were not being correctly picked in the artifacts files. This fixes the issue.

How Has This Been Tested?

Ran workflow and saw zfs-release RPMs included in artifacts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter
runners: Fix zfs-release RPM creation
864adc4 
The zfs-qemu-packages workflow was incorrectly copying the built
zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs.  This
meant that the RPMs were not being correctly picked in the artifacts
files.  This fixes the issue.

Signed-off-by: Tony Hutter <[email protected]>
mcmilk
mcmilk approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@mcmilk mcmilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I have overseen this in my review :/

@tonyhutter tonyhutter merged commit 240fc4a into openzfs:master Mar 26, 2025
16 of 17 checks passed
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Apr 3, 2025
@tonyhutter
runners: Fix zfs-release RPM creation (openzfs#17173)
59648fd 
The zfs-qemu-packages workflow was incorrectly copying the built
zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs.  This
meant that the RPMs were not being correctly picked in the artifacts
files.  This fixes the issue.

Signed-off-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: @ImAwsumm
Reviewed-by: Tino Reichardt <[email protected]>
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
@tonyhutter @FedorUporovVstack
runners: Fix zfs-release RPM creation (openzfs#17173)
1dab4a5 
The zfs-qemu-packages workflow was incorrectly copying the built
zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs.  This
meant that the RPMs were not being correctly picked in the artifacts
files.  This fixes the issue.

Signed-off-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: @ImAwsumm
Reviewed-by: Tino Reichardt <[email protected]>
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
@tonyhutter @FedorUporovVstack
runners: Fix zfs-release RPM creation (openzfs#17173)
8a33ba2 
The zfs-qemu-packages workflow was incorrectly copying the built
zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs.  This
meant that the RPMs were not being correctly picked in the artifacts
files.  This fixes the issue.

Signed-off-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: @ImAwsumm
Reviewed-by: Tino Reichardt <[email protected]>
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2025
@tonyhutter
runners: Fix zfs-release RPM creation (openzfs#17173)
8f6f854 
The zfs-qemu-packages workflow was incorrectly copying the built
zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs.  This
meant that the RPMs were not being correctly picked in the artifacts
files.  This fixes the issue.

Signed-off-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: @ImAwsumm
Reviewed-by: Tino Reichardt <[email protected]>
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request May 27, 2025
@tonyhutter
runners: Fix zfs-release RPM creation (openzfs#17173)
7a00807 
The zfs-qemu-packages workflow was incorrectly copying the built
zfs-release RPMs to ~/zfsonlinux.github.com rather than ~/zfs.  This
meant that the RPMs were not being correctly picked in the artifacts
files.  This fixes the issue.

Signed-off-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: @ImAwsumm
Reviewed-by: Tino Reichardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@mcmilk mcmilk mcmilk approved these changes

@ImAwsumm ImAwsumm ImAwsumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyhutter @behlendorf @mcmilk @ImAwsumm