Skip to content

simd_powerpc.h: enable FPU on FreeBSD #17191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

simd_powerpc.h: enable FPU on FreeBSD #17191

merged 1 commit into from
Apr 1, 2025

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented Mar 28, 2025 •
edited
Loading

FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Including machine/pcpu.h needs to be done before including sys/types.h, hence this order.

Motivation and Context

It enables ZFS to use assembly routines with SIMD.

Description

How Has This Been Tested?

Booting with ZFS on root on POWER9 workstation.

FreeBSD 14.2-RELEASE on POWER9, ZFS on /.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@pkubaj pkubaj force-pushed the patch-2 branch 2 times, most recently from 913a112 to 04a2341 Compare March 28, 2025 10:53
amotin
amotin reviewed Mar 28, 2025
View reviewed changes
@pkubaj pkubaj force-pushed the patch-2 branch 2 times, most recently from 5ed86e8 to cf36060 Compare March 28, 2025 16:36
amotin
amotin approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've committed it to FreeBSD before waiting for review here. I'll pass it this time, but you haven't even answered to one of my comments, so I assume you know what you are doing and there won't be a followup commit.

@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2025
@pkubaj
simd_powerpc.h: enable FPU on FreeBSD
38a93d9 
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Signed-off-by: Piotr Kubaj <[email protected]>
@pkubaj
Copy link
Contributor Author

pkubaj commented Mar 28, 2025

Sorry, I didn't notice your comment before committing to FreeBSD.
Inclusion of machine/pcpu.h was necessary in the earlier version of the patch but it looks like after I removed some later includes, it's not necessary anymore.

@github-actions github-actions bot removed the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2025
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 28, 2025
@amotin amotin merged commit 11ca12d into openzfs:master Apr 1, 2025
34 of 37 checks passed
robn pushed a commit to robn/zfs that referenced this pull request Apr 4, 2025
@pkubaj @robn
simd_powerpc.h: enable FPU on FreeBSD
c6b8138 
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Piotr Kubaj <[email protected]>
Closes openzfs#17191
(cherry picked from commit 11ca12d)
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 8, 2025
@pkubaj @tonyhutter
simd_powerpc.h: enable FPU on FreeBSD
43572d1 
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Piotr Kubaj <[email protected]>
Closes openzfs#17191
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
@pkubaj @FedorUporovVstack
simd_powerpc.h: enable FPU on FreeBSD
c393ec4 
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Piotr Kubaj <[email protected]>
Closes openzfs#17191
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
@pkubaj @FedorUporovVstack
simd_powerpc.h: enable FPU on FreeBSD
0b27036 
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Piotr Kubaj <[email protected]>
Closes openzfs#17191
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2025
@pkubaj @tonyhutter
simd_powerpc.h: enable FPU on FreeBSD
12657df 
FreeBSD nowadays supports FPU in the kernel on powerpc*, so enable it.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Piotr Kubaj <[email protected]>
Closes openzfs#17191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkubaj @behlendorf @amotin @tonyhutter