Skip to content

freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64 #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64 #17219

merged 1 commit into from
Apr 5, 2025

Conversation

mmatuska
Copy link
Contributor

@mmatuska mmatuska commented Apr 4, 2025 •
edited
Loading

Motivation and Context

When building the OpenZFS 2.3.1 kernel module port on FreeBSD (filesystems/openzfs-kmod)
that I maintain, I have got compilation errors on FreeBSD 15-CURRENT-arm64

Description

Do not compile foreign assembly files into the module.
This also reduces diff to the FreeBSD module Makefile.

How Has This Been Tested?

Compiling and running on FreeBSD 14-STABLE and 15-CURRENT i386, amd64 and arm64

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mmatuska
freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64
d7e46b2 
- don't include foreign machine assembly files
- reduce diff to FreeBSD module Makefile

Discovered in FreeBSD port filesystems/openzfs-kmod

Signed-off-by: Martin Matuska <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 5, 2025
@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 5, 2025
@amotin amotin merged commit 88e3885 into openzfs:master Apr 5, 2025
18 of 23 checks passed
@mmatuska mmatuska mentioned this pull request Apr 6, 2025
Merged
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 8, 2025
@mmatuska @tonyhutter
freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64
097f2f1 
- don't include foreign machine assembly files
- reduce diff to FreeBSD module Makefile

Discovered in FreeBSD port filesystems/openzfs-kmod

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Martin Matuska <[email protected]>
Closes openzfs#17219
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
@mmatuska @FedorUporovVstack
freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64
aee70dd 
- don't include foreign machine assembly files
- reduce diff to FreeBSD module Makefile

Discovered in FreeBSD port filesystems/openzfs-kmod

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Martin Matuska <[email protected]>
Closes openzfs#17219
fuporovvStack pushed a commit to fuporovvStack/zfs that referenced this pull request Apr 11, 2025
@mmatuska @FedorUporovVstack
freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64
7cc2a34 
- don't include foreign machine assembly files
- reduce diff to FreeBSD module Makefile

Discovered in FreeBSD port filesystems/openzfs-kmod

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Martin Matuska <[email protected]>
Closes openzfs#17219
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2025
@mmatuska @tonyhutter
freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64
c312a98 
- don't include foreign machine assembly files
- reduce diff to FreeBSD module Makefile

Discovered in FreeBSD port filesystems/openzfs-kmod

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Martin Matuska <[email protected]>
Closes openzfs#17219
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request May 2, 2025
@mmatuska @snajpa
freebsd: unbreak module/Makefile.bsd build on 15-CURRENT-arm64
2e38c40 
- don't include foreign machine assembly files
- reduce diff to FreeBSD module Makefile

Discovered in FreeBSD port filesystems/openzfs-kmod

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Martin Matuska <[email protected]>
Closes openzfs#17219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmilk mcmilk mcmilk approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmatuska @mcmilk @amotin