Skip to content
This repository was archived by the owner on Aug 22, 2022. It is now read-only.

Fixing dep tree #8

Closed
wants to merge 2 commits into from
Closed

Fixing dep tree #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23acc52
chore: update deps
daviddias Aug 24, 2017
a05274f
wip
daviddias Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
**/package-lock.json

node_modules/
*sublime*
dist/*.map
Expand Down
32 changes: 14 additions & 18 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,27 @@
"version": "0.1.0",
"description": "Orbit - Communication System on IPFS",
"main": "src/Orbit.js",
"browser": {
"fs-pull-blob-store": "idb-pull-blob-store"
},
"dependencies": {
"ipfs-post": "~0.1.0-beta.1",
"logplease": "^1.2.9",
"logplease": "^1.2.14",
"lru": "~3.1.0",
"orbit-crypto": "~0.1.0-beta.1",
"orbit-db": "~0.17.1"
"orbit-crypto": "~0.1.0-beta.2",
"orbit-db": "~0.17.3"
},
"devDependencies": {
"babel-core": "^6.14.0",
"babel-loader": "^6.2.5",
"babel-plugin-syntax-flow": "^6.13.0",
"babel-plugin-transform-flow-strip-types": "^6.14.0",
"babel-preset-es2015": "^6.14.0",
"bluebird": "^3.4.6",
"babel-core": "^6.26.0",
"babel-loader": "^7.1.2",
"babel-plugin-syntax-flow": "^6.18.0",
"babel-plugin-transform-flow-strip-types": "^6.22.0",
"babel-preset-es2015": "^6.24.1",
"bluebird": "^3.5.0",
"fs-pull-blob-store": "^0.4.1",
"idb-pull-blob-store": "^0.5.1",
"ipfs-daemon": "^0.3.0-beta.24",
"ipfs-test-apis": "^0.1.0-beta.4",
"json-loader": "^0.5.4",
"mocha": "^2.5.3",
"rimraf": "^2.5.4",
"webpack": "^2.1.0-beta.27"
"ipfs-test-apis": "^0.1.0-beta.5",
"json-loader": "^0.5.7",
"mocha": "^3.5.0",
"rimraf": "^2.6.1",
"webpack": "^3.5.5"
},
"scripts": {
"test": "mocha",
Expand Down
3 changes: 2 additions & 1 deletion src/Orbit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ class Orbit {
logger.debug(`Send message to #${channel}: ${message}`)

let data = {
content: message.substring(0, 2048),
// TODO: Question for Haad, why are you truncating messages?
content: new Buffer(message.substring(0, 2048)),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haadcode you were truncating every message. Is there a reason for that in Orbit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, yeah! :D That was a quick fix long time ago when some random tester on orbit started flooding with very long messages. It's not a great place to fix that problem but rather should be fixed on the lower levels (orbit-db side). If you can, leave it as it is now (truncate the message, do use buffers if you're changing them) and we'll handle that in the data structures or in orbit-db eventually. Sound good?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. The message format should be a dag so that it can growth to any length (or at least block large messages at the user interaction level).

replyto: replyToHash || null,
from: this.user
}
Expand Down