-
Notifications
You must be signed in to change notification settings - Fork 273
Create SouthTyrol-Cadastre.geojson #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
Thank you! Is this layer working? I didn't manage to make it work on iD, JOSM, or even in their GeoServer. |
"attribution": { | ||
"url": "https://geoservices.buergernetz.bz.it/geokatalog", | ||
"text": "© Autonome Provinz Bozen/Provincia Autonoma di Bolzano CC-BY 4.0", | ||
"required": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the data is CC BY then attribution is required so should be required: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and apologies it's been missed.
The service is working for me, but it looks like it would work better as an overlay above imagery rather than a background map. Could you set overlay: true
? Per the schema at
editor-layer-index/schema.json
Line 162 in d3f5b92
"overlay": { |
"name": "South Tyrol Cadastre", | ||
"start_date": "2024-09-02", | ||
"end_date": "2024-09-02", | ||
"best": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove best: true
this should be for imagery layers only.
"EPSG:32632" | ||
], | ||
"type": "wms", | ||
"category": "photo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change the category to either map
or other
since it's not an orthophoto. https://github.com/osmlab/editor-layer-index/blob/gh-pages/CONTRIBUTING.md#categories
"id": "SouthTyrol-Cadastre", | ||
"name": "South Tyrol Cadastre", | ||
"start_date": "2024-09-02", | ||
"end_date": "2024-09-02", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the data is continually updated, best leave off the start/end dates. Unless you know the data is fixed at this time period?
Could you also please remind me where the CC BY waiver is? |
Cadastre map from wms https://geoservices5.civis.bz.it/geoserver/p_bz-Cadastre/wms?request=getCapabilities