Skip to content

🐛 Specify badge endpoints returns content-type image/svg+xml #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

spencerschrock
Copy link
Member

We were previously saying the Content-Type header for the badge was application/json which was causing issues for proxies (e.g. go-camo which is used by pypi).

E.g: https://pypi.org/project/numpy shows a broken OpenSSF Scorecard badge.

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock force-pushed the fix/badge-content-type branch from 8cc15b6 to cd49724 Compare August 30, 2023 17:14
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for ossf-scorecard canceled.

Name Link
🔨 Latest commit 6ad98ed
🔍 Latest deploy log https://app.netlify.com/sites/ossf-scorecard/deploys/64ef7bee4e4487000879a900

@spencerschrock spencerschrock changed the title 🐛 Specify badge endpoints returns content-type image/* 🐛 Specify badge endpoints returns content-type image/svg+xml Aug 30, 2023
@spencerschrock spencerschrock marked this pull request as ready for review August 30, 2023 17:17
Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock merged commit e7be600 into ossf:main Aug 30, 2023
@spencerschrock spencerschrock deleted the fix/badge-content-type branch August 30, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants