fix GitHub markdown rendering by removing space from badge style #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the redirect was working locally with curl, I suspect the space
may be causing issues with GitHub's camo proxy. This suspicion is due to
a test README I did which directly linked failed to render:
spencerschrock
requested review from
a team,
justaugustus and
raghavkaul
and removed request for
a team
✅ Deploy Preview for ossf-scorecard canceled.
|
|
the failure to render in my small test is probably just due to the space, but this seems like a harmless change to make to test once it gets deployed to the staging instance |
raghavkaul
approved these changes
Apr 11, 2025
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ossf/scorecard#4591
While the redirect was working locally with curl, I suspect the space may be causing issues with GitHub's camo proxy. This suspicion is due to a test README I did which directly linked failed to render:
But using the plus seemed to render.