-
Notifications
You must be signed in to change notification settings - Fork 1
af/init command #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
af/init command #30
Conversation
clarification: i do not care about code formatting feedback, such as the compiler warnings for the structs or the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure comments:
- So far, I've tried to keep the bulk of the logic for comands in their own folders, and
run()
orchestrates which thing to call based on the command line flags (i.e.build::run()
calls build_image() and then push_images() if--push
was given). I think the*_init()
functions and the struct definitions should go in their own folder/file to follow this. Thoughts from the rest of the team?
done |
Since this PR is so out of date with the |
Opening a premature PR on this so that I can get midway feedback and get most of my "TODO" questions answered this Sunday (not all of the TODOs are for y'all but most of them are, feel free to comment on any you want to give insight on). Please add your answers to the TODOs via comments in a review on this PR since I can't be there this Sunday