Skip to content

cargo-psp workspace support #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 7, 2023
Merged

cargo-psp workspace support #125

merged 6 commits into from
Mar 7, 2023

Conversation

zetanumbers
Copy link
Contributor

@zetanumbers zetanumbers commented Jul 6, 2022 •
edited
Loading

Fixes #139 #146

Introduces workspace support, crate examples support. Also fixes --manifest-path.

Workspace changes i plan to publish as a separate PR.

@zetanumbers zetanumbers marked this pull request as ready for review July 6, 2022 14:39
@zetanumbers
Copy link
Contributor Author

zetanumbers commented Jul 6, 2022 •
edited
Loading

Maybe should rename example packages from psp-<name>-example to <name>. I don't see any good reason to keep them like that, and it simplifies typing.

@zetanumbers zetanumbers mentioned this pull request Jul 7, 2022
Draft
@zetanumbers zetanumbers force-pushed the examples-workspace branch 2 times, most recently from 8e8b287 to 8b6e522 Compare July 11, 2022 12:16
@zetanumbers zetanumbers changed the title Examples workspace cargo-psp workspace support Jul 11, 2022
@zetanumbers zetanumbers mentioned this pull request Jul 12, 2022
Merged
overdrivenpotato
overdrivenpotato requested changes Jul 30, 2022
View reviewed changes
@zetanumbers
Copy link
Contributor Author

I tested this PR and it works as expected. It's ready for merge.

@zetanumbers zetanumbers mentioned this pull request Mar 2, 2023
Closed
sajattack
sajattack approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@sajattack sajattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rebase this and try to get it merged :)

@zetanumbers
Copy link
Contributor Author

rebase done

@hatmajster
Copy link

I too confirm that by using this changes with cargo psp -p <package> works with a binary package in workspace.

sajattack
sajattack reviewed Mar 6, 2023
View reviewed changes
@sajattack sajattack merged commit 3c009a4 into overdrivenpotato:master Mar 7, 2023
@zetanumbers zetanumbers deleted the examples-workspace branch March 7, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajattack sajattack sajattack approved these changes

@overdrivenpotato overdrivenpotato Awaiting requested review from overdrivenpotato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo-psp tries to build the .prx and EBOOT.PBP for a non-PSP binary in a workspace
4 participants
@zetanumbers @hatmajster @sajattack @overdrivenpotato