uploads are not always resumed from where they stopped

[individual-it]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

When loosing and regaining connection to the server (ocis) during an active upload sometimes the upload does not always resume from the point where it stopped but starts from the beginning

Expected behavior

I expect the client always (when technically possible) to resume the upload and not re-upload already uploaded data

Steps to reproduce the issue

1. install nightly build of the oC client (3.0.0) in a Windows 10 Virtual Box
2. run current master of ocis in ubuntu (on Virtual Box host)
3. connect the oC client to ocis
4. disconnect the VBox network, so that the client cannot reach the server anymore
5. wait a while
6. connect the VBox network again
7. repeat step 4-6

Screenshots

Logs

owncloud-internet-connection.log

Client version number

ownCloud 3.0.0.8588-daily20220922 01f6a5
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19044

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

C:\Program Files\ownCloud\owncloud.exe

Server information

ocis master commitid: a5eb9611c07a9131128019228c77ab2f9daeeb4a
running on Ubuntu 22.10
fresh install

Additional context

No response

[TheOneRing]

Please retest with a recent client #10200

[bishwasojha]

This issue is still happening

When internet is disconnected more than once or twice , an error occurs and upload resumes from the start

Screenshots

Log
ownCloud.log

Client Version
ownCloud 3.0.0.8894-daily20221024 214ea7
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19044

Tested with the same setup as mentioned in the issue description

[bishwasojha]

Re-Tested this issue with Client Version

ownCloud 3.0.0.8954-daily20221028 67bafe
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19044

Issue is still happening

Screenshots

Logs:

internet-connection.txt

Tested with the same setup as mentioned in the issue description

[michaelstingl]

@HanaGemela @saw-jan not fully understood yet. Reliable steps to reproduce? Could you demo to us?

[saw-jan]

I believe the issue is about: resume upload after the network connection restores.

Steps:

1. Add a user account to desktop client (use ocis server)
2. try to sync large file
3. while syncing TURN OFF the internet connection
4. wait for client to show network error message (or grayed out)
5. TURN ON the internet connection
6. wait for sync to start and see if the upload resume from where it was stopped (not from the beginning of bytes)

[TheOneRing]

🤦‍♀️ It took me way to long to figure out whats going on.
We are using the creation-with-upload with workflow with (by default) 100mb chunks.
Only once we got one chunk uploaded we will be able to resume anything, as only then we receive an id by the server.

[michaelstingl]

We are using the creation-with-upload with workflow with (by default) 100mb chunks.

All the files in the screenshots look like 1GB or bigger, so multiple 100MB chunks should have been transferred before the connection was interrupted.

@TheOneRing did you check the linked logs?

[TheOneRing]

The test was performed when we didn't have an implementation of resumes with tus yet...

[Salipa-Gurung]

Client Version

ownCloud 5.0.0.11438-daily20230712 0f63d2
Libraries Qt 6.4.3, OpenSSL 3.1.1 30 May 2023
Using virtual files plugin: wincfapi
windows-10.0.19045

Server: ocis

Uploading file till 289 MB	Disconnecting network	Upload resumed from the point where it stopped ✔️