Include saved uploads in partial sync #10200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit test was implemented in #10199 |
TheOneRing
force-pushed
the
work/fix_testFinalMoveLocked
branch
from
9b5192a to
cad304a
Compare
fmoc
suggested changes
Oct 19, 2022
| @@ -1407,31 +1407,63 @@ SyncJournalDb::UploadInfo SyncJournalDb::getUploadInfo(const QString &file) | |||
| { | |||
| QMutexLocker locker(&_mutex); | |||
|
|
|||
|
|
|||
| if (!checkConnect()) { | |||
| return {}; | |||
There was a problem hiding this comment.
Should we log this case? It looks like this case should not occur really.
There was a problem hiding this comment.
The db code already logs.
I also assume we should remove 90% of the checkConnect calls the db is supposed to be opened at this point...
The checkConnect is also the function that checked for the existance of the db file before all our sql calls.
fmoc
approved these changes
Oct 19, 2022
Fixes: owncloud/enterprise#5382
TheOneRing
force-pushed
the
work/fix_testFinalMoveLocked
branch
from
55cfe99 to
3226f96
Compare
|
Kudos, SonarCloud Quality Gate passed! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.