Reverse order of migrations #9226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2021 07:09
This way, we won't accidentally migrate an older configuration if a newer one is available.
TheOneRing
reviewed
Nov 19, 2021
TheOneRing
reviewed
Nov 19, 2021
src/gui/application.cpp
Outdated
| } | ||
| } | ||
| } | ||
| } else { | ||
| // migration worked! | ||
| success = true; |
There was a problem hiding this comment.
Both branches migrate, I guess we should break in both?
TheOneRing
force-pushed
the
work/improve-migrations
branch
from
c83ed93 to
dd55430
Compare
TheOneRing
force-pushed
the
work/improve-migrations
branch
from
dd55430 to
ba4b40c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
erikjv
approved these changes
Nov 22, 2021
TheOneRing
pushed a commit
that referenced
this pull request
Nov 22, 2021
* Reverse order of paths to migrate This way, we won't accidentally migrate an older configuration if a newer one is available. * Add log prefix for non-legacy migration code as well * Also break if file-based migration works * Add stripTrailingSlash to Utility * Simplify code * Make configLocationsToMigrate const Co-authored-by: Hannah von Reth <[email protected]> (cherry picked from commit 78796ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #9224. Tested with testpilotcloud theme.