Skip to content

fix: improve some wordings and cli table #10015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: improve some wordings and cli table #10015

merged 2 commits into from
Sep 13, 2024

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Sep 9, 2024 •
edited
Loading

Description

Improve some wordings and cli output.

New Cli output after the fix

+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
|            NAME            |                 UID                  | ENABLED  |          DESCRIPTION           |           CONDITION            |         ALLOWED RESOURCE ACTIONS         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| Viewer                     | b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5 | enabled  | View and download.             | exists @Resource.File          | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                | exists @Resource.Folder        | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                | exists @Resource.File &&       | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                | exists @Resource.Folder &&     | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| ViewerListGrants           | d5041006-ebb3-4b4a-b6a4-7c180ecfb17d | disabled | View, download and show all    | exists @Resource.File          | libre.graph/driveItem/path/read          |
|                            |                                      |          | invited people.                | exists @Resource.Folder        | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                | exists @Resource.File &&       | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                | exists @Resource.Folder &&     | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| SpaceViewer                | a8d5fe5e-96e3-418d-825b-534dbdf22b99 | enabled  | View and download.             | exists @Resource.Root          | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| Editor                     | fb6c3e19-e378-47e5-b277-9732f9de6e21 | enabled  | View, download, upload, edit,  | exists @Resource.Folder        | libre.graph/driveItem/children/create    |
|                            |                                      |          | add and delete.                | exists @Resource.Folder &&     | libre.graph/driveItem/standard/delete    |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/update        |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| EditorListGrants           | e8ea8b21-abd4-45d2-b893-8d1546378e9e | disabled | View, download, upload, edit,  | exists @Resource.Folder        | libre.graph/driveItem/children/create    |
|                            |                                      |          | add, delete and show all       | exists @Resource.Folder &&     | libre.graph/driveItem/standard/delete    |
|                            |                                      |          | invited people.                | @Subject.UserType=="Federated" | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/update        |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| SpaceEditor                | 58c63c02-1d89-4572-916a-870abc5a1b7d | enabled  | View, download, upload, edit,  | exists @Resource.Root          | libre.graph/driveItem/children/create    |
|                            |                                      |          | add, delete including the      |                                | libre.graph/driveItem/standard/delete    |
|                            |                                      |          | history.                       |                                | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/versions/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/update        |
|                            |                                      |          |                                |                                | libre.graph/driveItem/versions/update    |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| SpaceEditorWithoutVersions | 3284f2d5-0070-4ad8-ac40-c247f7c1fb27 | disabled | View, download, upload, edit,  | exists @Resource.Root          | libre.graph/driveItem/children/create    |
|                            |                                      |          | add and delete.                |                                | libre.graph/driveItem/standard/delete    |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/update        |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| FileEditor                 | 2d00ce52-1fc2-4dbc-8b95-a73b73395f5a | enabled  | View, download and edit.       | exists @Resource.File          | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                | exists @Resource.File &&       | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| FileEditorListGrants       | c1235aea-d106-42db-8458-7d5610fb0a67 | disabled | View, download, edit and show  | exists @Resource.File          | libre.graph/driveItem/path/read          |
|                            |                                      |          | all invited people.            | exists @Resource.File &&       | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                | @Subject.UserType=="Federated" | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| EditorLite                 | 1c996275-f1c9-4e71-abdf-a42f6495e960 | enabled  | View, download and upload.     | exists @Resource.Folder        | libre.graph/driveItem/children/create    |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/update        |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| SpaceManager               | 312c0871-5ef7-4b3a-85b6-0e4074c64049 | enabled  | View, download, upload,        | exists @Resource.Root          | libre.graph/driveItem/permissions/create |
|                            |                                      |          | edit, add, delete and manage   |                                | libre.graph/driveItem/children/create    |
|                            |                                      |          | members.                       |                                | libre.graph/driveItem/standard/delete    |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/read          |
|                            |                                      |          |                                |                                | libre.graph/driveItem/quota/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/content/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/upload/create      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/read   |
|                            |                                      |          |                                |                                | libre.graph/driveItem/children/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/versions/read      |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/read       |
|                            |                                      |          |                                |                                | libre.graph/driveItem/path/update        |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/delete |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/delete     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/versions/update    |
|                            |                                      |          |                                |                                | libre.graph/driveItem/deleted/update     |
|                            |                                      |          |                                |                                | libre.graph/driveItem/basic/read         |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/update |
|                            |                                      |          |                                |                                | libre.graph/driveItem/permissions/deny   |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+
| SecureViewer               | aa97fe03-7980-45ac-9e50-b325749fd7e6 | disabled | View only documents, images    | exists @Resource.File          | libre.graph/driveItem/path/read          |
|                            |                                      |          | and PDFs. Watermarks will be   | exists @Resource.Folder        | libre.graph/driveItem/children/read      |
|                            |                                      |          | applied.                       |                                | libre.graph/driveItem/basic/read         |
+----------------------------+--------------------------------------+----------+--------------------------------+--------------------------------+------------------------------------------+

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested a review from kulmann as a code owner September 9, 2024 14:24
@micbar micbar requested a review from fschade September 9, 2024 15:04
@mmattel
Copy link
Contributor

mmattel commented Sep 10, 2024

Couldn't we add a column at the beginning with the name of the unified role like UnifiedRoleSecureViewerID. That would ease purpose identification a lot...

@micbar
Copy link
Contributor Author

micbar commented Sep 13, 2024

UnifiedRoleSecureViewerID

Couldn't we add a column at the beginning with the name of the unified role like UnifiedRoleSecureViewerID. That would ease purpose identification a lot...

I added that to the table, because i cannot afford having you complaining about me 😍

@fschade
Copy link
Contributor

fschade commented Sep 13, 2024

UnifiedRoleSecureViewerID

Couldn't we add a column at the beginning with the name of the unified role like UnifiedRoleSecureViewerID. That would ease purpose identification a lot...

I added that to the table, because i cannot afford having you complaining about me 😍

🤣 🚀 🎸

@micbar micbar enabled auto-merge September 13, 2024 12:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@micbar micbar merged commit 36df509 into master Sep 13, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Sep 13, 2024
@micbar
Merge pull request #10015 from owncloud/fix-roles-wording
c05b4f9 
fix: improve some wordings and cli table
@micbar micbar deleted the fix-roles-wording branch September 16, 2024 07:16
This was referenced Sep 17, 2024
Merged
Open
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@JammingBen JammingBen JammingBen left review comments

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @mmattel @fschade @JammingBen