Skip to content

[tests-only] Categorize expected-failures files #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2021
Merged

[tests-only] Categorize expected-failures files #1548

merged 2 commits into from
Jan 29, 2021

Conversation

phil-davis
Copy link
Contributor

Description

  1. Copy the categorized expected-failures files that were done in Categorize expected OCIS failures cs3org/reva#1424 and [tests-only] Categorize expected-failures-on-OWNCLOUD-storage cs3org/reva#1426 into owncloud/ocis
  2. Adjust them for the current expected-failures here in owncloud/ocis

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jan 29, 2021
@phil-davis phil-davis marked this pull request as ready for review January 29, 2021 07:04
@phil-davis phil-davis force-pushed the categorize-expected-failures branch 2 times, most recently from 0d197f2 to c1035c1 Compare January 29, 2021 10:24
individual-it
individual-it approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it passes it must be good

@phil-davis phil-davis force-pushed the categorize-expected-failures branch from c1035c1 to 2f73400 Compare January 29, 2021 11:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 34d5330 into master Jan 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the categorize-expected-failures branch January 29, 2021 12:57
ownclouders pushed a commit that referenced this pull request Jan 29, 2021
@phil-davis
commit 34d5330
75b795a 
Merge: 4aea7a9 2f73400
Author: Phil Davis <[email protected]>
Date:   Fri Jan 29 18:42:08 2021 +0545

    Merge pull request #1548 from owncloud/categorize-expected-failures

    [tests-only] Categorize expected-failures files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@butonic butonic Awaiting requested review from butonic

@dpakach dpakach Awaiting requested review from dpakach

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @individual-it