Skip to content

fix(password-protected-folders): delete hidden folder when either link or file creation fails #12241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix(password-protected-folders): delete hidden folder when either link or file creation fails #12241

merged 1 commit into from
Mar 5, 2025

Conversation

LukasHirt
Copy link
Collaborator

Description

Hidden folder created during password protected folder gets deleted now in case its link or the psec file creation fails.

Related Issue

Motivation and Context

There is no zombie folder left which prevents same name folder creation.

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: create a folder with insufficient password

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Mar 5, 2025
@LukasHirt LukasHirt requested a review from mzner March 5, 2025 10:26
@LukasHirt LukasHirt self-assigned this Mar 5, 2025
@LukasHirt LukasHirt mentioned this pull request Mar 5, 2025
Closed
16 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LukasHirt LukasHirt enabled auto-merge March 5, 2025 11:13
@LukasHirt LukasHirt merged commit c7fb778 into master Mar 5, 2025
4 checks passed
@LukasHirt LukasHirt deleted the fix/revert-password-protected-folder branch March 5, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzner mzner mzner approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password-Protected Folder Creation Fails Due to Policy and Duplicate Folder Name
2 participants
@LukasHirt @mzner