Skip to content

bugfix: create only one space/folder when user presses enter on modal #12297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mzner
Copy link
Contributor

@mzner mzner commented Mar 11, 2025

This bugfix addresses an issue where pressing the Enter key in a modal to create a space or folder results in the creation of two spaces or folders instead of just one. The fix ensures that only a single space or folder is created when the Enter key is pressed.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Mar 11, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mzner mzner force-pushed the bugfix/keydown-enter-leads-to-two-spaces-being-created branch from 5eb6332 to af443fb Compare March 11, 2025 12:17
@mzner mzner requested a review from LukasHirt March 11, 2025 12:17
@mzner mzner force-pushed the bugfix/keydown-enter-leads-to-two-spaces-being-created branch from af443fb to ec3baf6 Compare March 11, 2025 13:31
@LukasHirt LukasHirt merged commit 48c8e2d into master Mar 13, 2025
4 checks passed
@LukasHirt LukasHirt deleted the bugfix/keydown-enter-leads-to-two-spaces-being-created branch March 13, 2025 08:50
@LukasHirt LukasHirt mentioned this pull request Mar 10, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two spaces are created at the same time when user is trying to create a space
2 participants