fix(minifier): avoid minifying +void unknown to NaN and fix typo
#8784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
7086cmd
changed the title
+void unknown to NaN resolves #8782. This bug appears when we are arbitrarily eliminating potential side-effective elements in unary expression.+void unknown to NaN resolves #8782.
7086cmd
changed the title
+void unknown to NaN resolves #8782.+void unknown to NaN
CodSpeed Performance ReportMerging #8784 will not alter performanceComparing Summary
|
7086cmd
force-pushed
the
01-30-feat_minifier_implement_variadic_math_methods_in_known_methods
branch
from
ef16e27 to
abc84d1
Compare
7086cmd
force-pushed
the
01-30-fix_minifier_avoid_minifying_void_unknown_to_nan_resolves_8782._this_bug_appears_when_we_are_arbitrarily_eliminating_potential_side-effective_elements_in_unary_expression
branch
from
2a37266 to
bb39d43
Compare
7086cmd
force-pushed
the
01-30-feat_minifier_implement_variadic_math_methods_in_known_methods
branch
from
abc84d1 to
42f7235
Compare
7086cmd
force-pushed
the
01-30-fix_minifier_avoid_minifying_void_unknown_to_nan_resolves_8782._this_bug_appears_when_we_are_arbitrarily_eliminating_potential_side-effective_elements_in_unary_expression
branch
from
bb39d43 to
c23a256
Compare
7086cmd
force-pushed
the
01-30-fix_minifier_avoid_minifying_void_unknown_to_nan_resolves_8782._this_bug_appears_when_we_are_arbitrarily_eliminating_potential_side-effective_elements_in_unary_expression
branch
from
c23a256 to
735a5b6
Compare
7086cmd
changed the base branch from
01-30-feat_minifier_implement_variadic_math_methods_in_known_methods
to
main
7086cmd
changed the title
+void unknown to NaN+void unknown to NaN and fix typo
Merge activity
|
Boshen
force-pushed
the
01-30-fix_minifier_avoid_minifying_void_unknown_to_nan_resolves_8782._this_bug_appears_when_we_are_arbitrarily_eliminating_potential_side-effective_elements_in_unary_expression
branch
from
3803fd8 to
ae7f670
Compare
graphite-app
bot
deleted the
01-30-fix_minifier_avoid_minifying_void_unknown_to_nan_resolves_8782._this_bug_appears_when_we_are_arbitrarily_eliminating_potential_side-effective_elements_in_unary_expression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8782
This bug appears when we arbitrarily eliminate potential side-effective elements in unary expression.