ICMP support work for opte#369 #33
Open
+356
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub const fn payload_is_packet(self) -> bool { | ||
| matches!( | ||
| self, | ||
| Self::DESTINATION_UNREACHABLE |
There was a problem hiding this comment.
Thanks for covering the additional cases beyond DU here. Time exceeded will be important for traceroute to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines additional ICMP and ICMP v6 message types for use within body transforms in OPTE -- primarily, those which can carry nested packets as their payloads. This includes a few Neighbor Discovery Protocol option classes.
To help handle ICMPv6/NDP options, the
Ingotderive macro now allows for thevar_lenexpression to be omitted (as in subparse packet definitions). This causes such headers to consume the remainder of the slice they are parsed from.