improvements to the external interface #8274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahl
commented
Jun 4, 2025
ahl
commented
- remove the "hidden" tag and split into more explicit tags
- export tuf/upgrade related entrypoints
- clean up docs inappropriate for the public docs
- remove the "hidden" tag and split into more explicit tags - export tuf/upgrade related entrypoints - clean up docs inappropriate for the public docs
|
This improvement is really nice, it'll be great to have more clarity around tags. Would it be OK to wait and merge this for the next release to have a bit of time to adapt the Go SDK? |
The primary goal is to unblock CLI-driven update demos. |
|
Ah, gotcha! I assume you mean that the main goal is the new |
karencfv
added a commit
to oxidecomputer/oxide.go
that referenced
this pull request
Jun 24, 2025
oxidecomputer/omicron#8274 changed the way "hidden" endpoints were handled. In place of this "hidden" tag, we now have "experimental" and "console-auth". This commit updates the generator to handle the change in these tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.