Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to install groups #424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheSuperiorStanislav
Copy link

@TheSuperiorStanislav TheSuperiorStanislav commented Sep 5, 2024

Summary

Add the ability to specify which groups will be installed while making the main group as default one

Use Cases

When building for different environments like dev or prod. Would might need some dev tools, while prod is the opposite.

Closes #180

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Copy link

linux-foundation-easycla bot commented Sep 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: TheSuperiorStanislav / name: Stanislav Khlud (7e21fc3)

@TheSuperiorStanislav TheSuperiorStanislav marked this pull request as ready for review September 5, 2024 10:42
@TheSuperiorStanislav TheSuperiorStanislav requested a review from a team as a code owner September 5, 2024 10:42
@TheSuperiorStanislav TheSuperiorStanislav force-pushed the feature/add-ability-to-install-only-groups branch from 3dd8c1e to c52d39a Compare September 5, 2024 10:55
@TheSuperiorStanislav
Copy link
Author

@robdimsdale could you take a look? Pretty please)

@TheSuperiorStanislav
Copy link
Author

@robdimsdale pinging one more time, because our team would like to have it

@TheSuperiorStanislav
Copy link
Author

@robdimsdale Sorry for pinging, don't want this to go to waste. Could you take a look or ping somebody who could?

@dmikusa
Copy link

dmikusa commented Feb 25, 2025

The PR seems OK to me. I am by no means a poetry expert, but what you're proposing sounds reasonable and it doesn't sound like it will change the existing or default behavior.

The PR is stuck because Github didn't run the tests for some reason. I don't know of a way to fix this, but if you just push up a new commit that should trigger the actions again and hopefully Github will run them this time. I haven't tried, but looks like you can push an empty commit to do this too. Anyway, give that a shot and let me know. I might need to approve them to be run too.

@TheSuperiorStanislav TheSuperiorStanislav force-pushed the feature/add-ability-to-install-only-groups branch from c52d39a to 7e21fc3 Compare February 26, 2025 05:13
@TheSuperiorStanislav
Copy link
Author

I guess I need approval
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question ❓] How to install only "root/run" dependencies and ignore other groups dependencies
2 participants