ignore empty string class name when building dataflow metadata #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe field is absent and thus matches empty string, including all of these unwanted properties
tinedel
force-pushed
the
issue-438-trailing-comma-bug
branch
from
9b161d3 to
0f0a654
Compare
|
@kohlmu-pivotal are you ok with this change? |
anthonydahanne
added
type:bug
|
@anthonydahanne sure, no problem. Please let me know when you are ready and I'll update my branch with the latest main |
@anthonydahanne , yes I'm ok with this change. Ignore empty class names is what I would have done as well. |
pivotal-david-osullivan
approved these changes
Apr 2, 2024
pivotal-david-osullivan
merged commit d0e36ce
into
paketo-buildpacks:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #438
A lot of properties generated by configuration metadata do not have sourceType field set, which in turn matches the empty class name for the case when a list of classes has a trailing comma in the config file.
Checklist