feat: paloma bridge exit tax #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maharifu
force-pushed
the
lcarvalho/1709-bridge-tax-governance
branch
from
dc55880 to
9ec464d
Compare
|
- On receiving the transfer complete event we burn the total amount of tokens (transferred + taxed) @maharifu to be clear, we're not BURNING THE TOTAL AMOUNT OF TOKENS! RIGHT? RIGHT?!?!? |
taariq
requested changes
Jun 18, 2024
byte-bandit
requested changes
Jun 19, 2024
maharifu
force-pushed
the
lcarvalho/1709-bridge-tax-governance
branch
2 times, most recently
from
1b41622 to
927fde9
Compare
The amount transferred out of gravity is the intended amount minus the tax valus as set by governance vote.
CVE-2022-23772 was fixed in go 1.17.7 and backported to 1.16.14. We're using go 1.22, so it doesn't affect us.
The `skip-pkg-cache` and `skip-build-cache` options were removed in v5.
maharifu
force-pushed
the
lcarvalho/1709-bridge-tax-governance
branch
from
927fde9 to
2cbd798
Compare
Instead of subtracting from amount to transfer, we transfer the full amount and add the tax as a transfer cost to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
We're going to charge a tax fee for every transfer out of paloma. The tax rate is defined by governance vote and we can set exceptions to tokens and addresses.
Testing completed
Breaking changes