Skip to content

customFetch is not exported from index.js #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
tripodsan opened this issue Feb 26, 2025 · 1 comment
Closed
2 tasks done

customFetch is not exported from index.js #762

tripodsan opened this issue Feb 26, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@tripodsan
Copy link

What happened?

Since 6.x one can provide fetch via the customFetch symbol. Unfortunately, it is not exported from the index.js. I can see it exported as type in index.ts

jose/src/index.ts

Line 43 in 7ab375c

customFetch,

but it's not available in the js build.

side note: why is it exported as symbol and not just as a normal property like all other options?

Version

6.0.7

Runtime

Node.js

Runtime Details

v20.17.0

Code to reproduce

.

Required

  • I have searched the issues tracker and discussions for similar topics and couldn't find anything related.
  • I agree to follow this project's Code of Conduct
panva added a commit that referenced this issue Feb 26, 2025
@panva
fix: export [customFetch] symbol from the default entrypoint
1615614 
closes #762
@panva panva added bug Something isn't working and removed triage labels Feb 26, 2025
@panva
Copy link
Owner

panva commented Feb 26, 2025

Fixed in https://github.com/panva/jose/releases/tag/v6.0.8

@panva panva closed this as completed Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panva @tripodsan