Skip to content

fix(typescript): findAccount may return undefined #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2020
Merged

fix(typescript): findAccount may return undefined #786

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3c23c
fix(types): findAccount may return null or undefined
jstewmon Sep 18, 2020
b6f6cbf
Update types/index.d.ts
panva Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export {};

export type CanBePromise<T> = Promise<T> | T;
export type RetryFunction = (retry: number, error: Error) => number;
export type FindAccount = (ctx: KoaContextWithOIDC, sub: string, token?: AuthorizationCode | AccessToken | DeviceCode) => CanBePromise<Account>;
export type FindAccount = (ctx: KoaContextWithOIDC, sub: string, token?: AuthorizationCode | AccessToken | DeviceCode) => CanBePromise<Account | undefined | null>;
export type TokenFormat = 'opaque' | 'jwt' | 'jwt-ietf' | 'paseto';

export type AccessTokenFormatFunction = (ctx: KoaContextWithOIDC, token: AccessToken) => TokenFormat;
Expand Down
20 changes: 11 additions & 9 deletions types/oidc-provider-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,17 @@ const provider = new Provider('https://op.example.com', {
token.iat.toFixed();
}

return {
accountId: sub,
async claims() {
return {
sub,
foo: 'bar',
};
},
};
if (Math.random() > 0.5) {
return {
accountId: sub,
async claims() {
return {
sub,
foo: 'bar',
};
},
};
}
},
async rotateRefreshToken(ctx) {
ctx.oidc.issuer.substring(0);
Expand Down