Remove profile listener #648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes sense to remove for now, but I would recommend to have something HTTP based for debugging purposes when we reintroduce this instead of something FS based. It tends to be much more difficult to have FS access than let's say do a port-forward in Kubernetes. |
kakkoyun
requested changes
Aug 2, 2022
|
Sure thing, we can re-add this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile listener was used to intercept profile writes when downloading pprof files from the UI. This functionality has been removed in #627, and if we decide to add something like this back, we will probably save the pprof files directly to the FS, just before they are sent to the async client, avoiding the need for this wrapper.