Skip to content

[stable2506] Backport #8832 #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: stable2506
Choose a base branch
from
Open

[stable2506] Backport #8832 #8847

wants to merge 3 commits into from

Conversation

paritytech-release-backport-bot[bot]
Copy link

Backport #8832 into stable2506 from alexggh.

See the documentation on how to use this bot.

@alexggh @sandreim @github-actions
increase session index cache (#8832)
be23b56 
A 10 session index cache is not enough when you run under intense
pressure and finality is lagg since you will end requesting the session
index for blocks older than that. So let's make this cache larger to
achieve its purpose even under intense load when it actually matters
more to be faster.

The session_index_cache keeps a Hash and a u32, so that's about 36 bytes
per entry, with this increase it can grow up to 65k which is not that
big in my book.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit cadf3ac)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jun 12, 2025
@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Jun 12, 2025
Merged
@github-actions github-actions bot requested a review from alexggh June 12, 2025 16:13
@github-actions GitHub Actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@alexggh alexggh alexggh approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorPopelyaev @alexggh