fatxpool: ChainApi is now async
#8875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
added
R0-no-code-change
|
/cmd prdoc --bump minor --audience node_dev |
…-audience node_dev'
skunert
reviewed
Jun 17, 2025
| @@ -55,30 +55,30 @@ fn to_tag(nonce: u64, from: AccountId) -> Tag { | |||
| data.to_vec() | |||
| } | |||
|
|
|||
| #[async_trait] | |||
There was a problem hiding this comment.
DQ: With async traits stabilized, do we even need this?
There was a problem hiding this comment.
#[async_trait] also makes a future Send. I've just tried removing this and run into some lengthy errors which seems to be related to it.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
1 task
skunert
approved these changes
Jun 19, 2025
iulianbarbu
approved these changes
Jun 22, 2025
ggwpez
removed
the
R0-no-code-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainApiis nowasync_trait,validate_transactionandblock_bodyare nowasyncmethods. This is just cleanup - migrating from returningFuturetoasyncmethod