[pallet-revive] Make Runtime call dispatchable as eth transaction #8883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
the
T7-smart_contracts
…time_dev --bump patch'
athei
reviewed
Jun 18, 2025
| storage_deposit_limit, | ||
| data, | ||
| if dest == RUNTIME_PALLETS_ADDR { | ||
| let call = CallOf::<Self::Config>::decode(&mut &data[..]).map_err(|_| { |
There was a problem hiding this comment.
Needs a decode_with_max_depth or something. You need to check where it is decoded elsewhere.
There was a problem hiding this comment.
probably fine to apply the same limit as in https://github.com/paritytech/polkadot-sdk/blob/pg/fix-extension-weight/substrate/frame/executive/src/lib.rs?plain=1#L801-L798
made the changes here:
eadfed3
- Use the extension_weight of the eth transact, not the transformed one in both the dry-run and Checkable trait
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
athei
approved these changes
Jun 20, 2025
xermicus
approved these changes
Jun 20, 2025
smiasojed
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make RuntimeCall dispatchable as eth transaction.
By sending a transaction to
0x6d6f646c70792f70616464720000000000000000, using the encoded runtime call as input, the call will be executed by the origin indicated by the Ethereum signature (0xEE account_id).see paritytech/foundry-polkadot#130
e.g sending a remark_with_event
also merged in #8901 and #8920