Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add pallets/foreign-assets endpoint #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pallets/foreign-assets endpoint #1314
Changes from 6 commits
e1aa255
e682fbd
e9ca2e4
eb9628e
0683642
07fddc4
cc4b02b
2c418c7
c8b6d7e
151396b
e87cede
34a04ec
dae423e
1df530f
8efc7f2
20f967e
ffb3d54
2d49b26
b4dd1f3
646083a
1ecc91b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above we need to correctly type the entries method. This is because both
assetStorageKeyData
, andassetInfo
will have there own specific types.assetStorageKeyData: StorageKey<AnyTuple>
assetInfo: Option<PalletAssetsAssetDetails>
This will all ensure that the above is typed correctly so we wont need to type cast anymore and we can clean up all the types within the service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is amazing!!! Thank you so much @TarikGul for spending the time to explain and showcase this. I was fighting with the types quite a bit and now I get the logic! 🙏 🙏 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think it's assetMetadata we need to check here, but instead
if (assetInfo.isSome)
, and then we need to unwrap the value when we key it intoforeignAssetInfo: assetInfo.unwrap()
.But then we need to handle the case where the info is not available in an else statement. Such that if it doesn't exist we return an empty object.