-
Notifications
You must be signed in to change notification settings - Fork 159
feat: add asset-conversion endpoints #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2e-tests/historical/endpoints/asset-hub-westend/accounts/asset-balances/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really great job, just a few nits to resolve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! A very small nit/question. Once any lingering merge conflicts are handled looks good to go :)
In terms of the failing docker check in gitlab, I think its not relevant to your PR but a version of |
Closes issue #1308
Description
Adds the endpoints
/pallets/asset-conversion/liquidity-pools
which returns an array of the existing liquidity pool tokens, and/pallets/asset-conversion/next-available-id
which returns a string of the next available liquidity pool's id.Query Params
at
: Which block to query, defaults to latest finalized block if empty. Accepts a hash or a block number.Sample Response
While connected to
Westend Assst Hub
and requesting/pallets/liquidity-pools
, the return result is/should be simmilar to the following :While connected to
Westend Asset Hub
and requesting/pallets/next-available-id
, the return result is/should be the following :TODO