Skip to content

chore(deps): bump winston from 3.16.0 to 3.17.0 #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2024

Bumps winston from 3.16.0 to 3.17.0.

Release notes

Sourced from winston's releases.

v3.17.0

  • Try winston-transport 4.9.0 3e87128
  • Revert "Try bumping winston-transport to 4.8.0" 69625fc
  • Revert "Try bumping winston-transport to 4.8.0" 876ef7a
  • Try bumping winston-transport to 4.8.0 7ef2c1d
  • Try bumping winston-transport to 4.8.0 fe4b64e
  • Bump logform c9fd9a4
  • Revert "Update logform and winston-transport" 14fef0f
  • Merge branch 'master' of github.com:winstonjs/winston 545b683
  • Update logform and winston-transport cceb265
  • Bump mocha from 10.7.3 to 10.8.2 (#2523) bb529b6
  • Bump async from 3.2.5 to 3.2.6 (#2516) ae847ab

winstonjs/winston@v3.16.0...v3.17.0

Commits
  • 1b9cef8 3.17.0
  • 3e87128 Try winston-transport 4.9.0
  • 69625fc Revert "Try bumping winston-transport to 4.8.0"
  • 876ef7a Revert "Try bumping winston-transport to 4.8.0"
  • 7ef2c1d Try bumping winston-transport to 4.8.0
  • fe4b64e Try bumping winston-transport to 4.8.0
  • c9fd9a4 Bump logform
  • 14fef0f Revert "Update logform and winston-transport"
  • 545b683 Merge branch 'master' of github.com:winstonjs/winston
  • cceb265 Update logform and winston-transport
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [winston](https://github.com/winstonjs/winston) from 3.16.0 to 3.17.0.
- [Release notes](https://github.com/winstonjs/winston/releases)
- [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md)
- [Commits](winstonjs/winston@v3.16.0...v3.17.0)

---
updated-dependencies:
- dependency-name: winston
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner November 11, 2024 15:07
@dependabot dependabot bot added the D0 - Dependencies Pull requests that update a dependency file label Nov 11, 2024
@Imod7
Copy link
Contributor

Imod7 commented Nov 11, 2024

Updated the PR with this commit to fix the type and lint errors.

In winston v3.17.0, the logformpackage was bumped to v2.7.0 which includes this change. With this update, in TransformableInfo interface, the elements/properties that were of type any now are of type unknown. So, in Sidecar in order to make our code work, I did the following changes :

  • I completely removed the custom ITransformableInfo interface that set the properties of type any (which is now unknown) to string
  • I now use directly the TransformableInfo interface from logform package
  • The properties that now are of type unknown, I type assert to string with as string

I think this solution should be fine but also it is the only way I could make it work :) I tried to keep the custom ITransformableInfo but I could not set the properties I wanted to string so at the end I just had a duplicate of TransformableInfo interface.

Note
I did not use any type checking (if typeof ...) to check if the actual variable is a string before asserting but I think it should be ok.

@Imod7 Imod7 merged commit fb81a16 into master Nov 11, 2024
13 of 14 checks passed
@Imod7 Imod7 deleted the dependabot/npm_and_yarn/winston-3.17.0 branch November 11, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0 - Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants