Skip to content

Add chainName to server connecting message #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2020
Merged

Add chainName to server connecting message #158

merged 3 commits into from
Jul 9, 2020

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Jul 8, 2020 •
edited
Loading

Screen Shot 2020-07-08 at 11 22 51 AM

@emostov emostov requested a review from joepetrowski July 8, 2020 18:21
joepetrowski
joepetrowski reviewed Jul 8, 2020
View reviewed changes
@emostov
Copy link
Contributor Author

emostov commented Jul 8, 2020

Screen Shot 2020-07-08 at 1 23 09 PM

We still have NAME as an env variable. In theory, NAME could be helpful if someone is managing multiple instances of sidecar.

@emostov emostov requested a review from joepetrowski July 8, 2020 20:28
@joepetrowski joepetrowski merged commit 7379b39 into master Jul 9, 2020
@joepetrowski joepetrowski deleted the zeke-chainName branch July 9, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emostov @joepetrowski