Duplicated Menu Items when Running Docs Locally

[jme783]

Live reload is causing a full rebuild of Metalsmith, and the sidebar menu navigation. This causes duplicate page headers during development, and the links often times do not correctly link to the proper pages.

We should figure out a way to trigger the metalsmith rebuild to be more specific and targeted, and not trigger a full rebuild.

[monkbroc]

tl;dr this isn't something I managed to fix quickly so I'll punt it until later :(

This is due to the interaction between metalsmith-watch and metalsmith-collections.

The run operation in metalsmith-collections is not idempotent so running it multiple times corrupts the collections metadata in metalsmith.metadata(). The collections are stored both directly in metadata and in metadata.collections.

When metalsmith-watch sees a file change, it triggers a metalsmith.run for that file. In turn this runs metalsmith-collections.run() only for that file and it adds a duplicate section.

In addition, metalsmith-watch has a LOT of code specifically to deal with the limitations in metalsmith-collections. It backs up the collections, then tries to restore them after the metalsmith.run(). It must have worked at some point in the past, but currently the hacks don't match the metadata layout metalsmith-collections so it just ends up making things worse (links don't link to proper pages).

[jme783]

Gotcha, thanks for looking into this @monkbroc. Is there any way we could create an issue somewhere on the metalsmith-watch or metalsmith-collections repos to raise visibility on this and get the maintainers of those libraries working on a fix?

[monkbroc]

There has been an issue opened in collections for more than a year with tons of comments. That repo looks unmaintained.

[jme783]

Gotcha. 👎 for Metalsmith ugh.

[monkbroc]

Maybe the fork linked in this comment will help. I'll investigate later
metalsmith/collections#27 (comment)

[jme783]

Cool! Let's try it

[jme783]

I'll actually give this a try -- I'm spinning up a new branch right now

[jme783]

Argh...wasn't able to figure out how to get this to work because we already forked and changed the metalsmith-collections repo: https://github.com/spark/metalsmith-collections#dynamic-collections

I don't want to suck too much time into this, so I'm gonna move on for now. Let me know if you take a stab

[monkbroc]

Sad trombone 🎵

[brandoaire]

I believe that this has been fixed. @rickkas7 can comment.

[jme783]

Confirmed this is still an issue.