fix(ui): toggle list selections off on successful bulk action #12861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR threads an onSuccess callback to bulk actions which get called after a successful action. In this case, the callback toggles the list selections off after a successful edit many, publish many, or unpublish many.
Why?
To ensure list selections are toggled off after a successful action.
How?
By threading a new onSuccess callback through the actions' props.
Fixes #12855
Before
CleanShot.2025-06-18.at.11.24.39.mp4
After
Draft-Posts---Payload.webm
Notes:
test/bulk-edit
. However, the way the checkbox input seems to work is via defaultChecked and onInput instead of checked and onChange, which seems to make the checkboxes checked dom property lag a render behind (meaning expect().toBeChecked() can be misleading or return the wrong value). Open to suggestions here.