resolve issue #18 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

wangchen615 wants to merge 1 commit into release-v0.1.0 from iss18

Collaborator

wangchen615 commented Feb 25, 2021

This PR is to fix and close issue #18 .

The LibraryClient failed to getLatestMetrics when using it in plugins.

Make the following changes.

Separate the watcher from the LibraryClient
Allow the LibraryClient to fetch data only once.
Add a dummy service client code (commented) in main.go .


          resolve issue #18

ef0b684

wangchen615 requested a review from zorro786

February 25, 2021 04:02

wangchen615 self-assigned this

Collaborator Author

wangchen615 commented Feb 25, 2021

I am closing this because #18 will be solved by a new PR.

wangchen615 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet