Skip to content

fix: add name to pdm new #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

yihong0618
Copy link
Contributor

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

close #3468

Signed-off-by: yihong0618 <[email protected]>
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (39e082a) to head (f1b1856).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/cli/commands/init.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3476      +/-   ##
==========================================
- Coverage   85.61%   85.58%   -0.03%     
==========================================
  Files         113      113              
  Lines       11592    11597       +5     
  Branches     2545     2547       +2     
==========================================
+ Hits         9924     9925       +1     
- Misses       1138     1141       +3     
- Partials      530      531       +1     
Flag Coverage Δ
unittests 85.38% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: yihong0618 <[email protected]>
Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a news fragment to news/ directory?

@yihong0618
Copy link
Contributor Author

LGTM, can you add a news fragment to news/ directory?

of course

Signed-off-by: yihong0618 <[email protected]>
@frostming frostming merged commit 8102a58 into pdm-project:main Apr 16, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --name option for pdm init and pdm new
2 participants