Skip to content

Split htpy into multiple private modules #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2025
Merged

Conversation

jodal
Copy link
Contributor

@jodal jodal commented May 25, 2025

This is an updated version of #109, as requested in #109 (comment)

The only changes to htpy/* since #109 was created that I found are #112 and #117, which have both been applied to the first commit here.

jodal added 6 commits May 25, 2025 23:38
We only import markupsafe in private modules, so it doesn't need to be
aliased to avoid leaking the import.
It is still private as it is defined and exclusively used in
private modules or inside functions.
These are still private as they are defined and exclusively used in
private modules.
These are still private as they are defined and exclusively used in
private modules.
These are still private as they are defined and exclusively used in
private modules.
@pelme pelme merged commit 7459e8d into pelme:main May 26, 2025
14 checks passed
@jodal jodal deleted the module-split branch May 26, 2025 19:10
@jodal jodal mentioned this pull request May 26, 2025
4 tasks
jodal added a commit to jodal/htpy that referenced this pull request May 31, 2025
In pelme#119, all markupsafe imports were updated to simply `import
markupsafe`. This change was not applied to pelme#113 before it was merged.
pelme pushed a commit that referenced this pull request May 31, 2025
In #119, all markupsafe imports were updated to simply `import
markupsafe`. This change was not applied to #113 before it was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants