PMM-14009 Bundle Advisors with PMM #4106
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #4106 +/- ##
==========================================
+ Coverage 44.18% 44.28% +0.09%
==========================================
Files 373 373
Lines 45903 45659 -244
==========================================
- Hits 20282 20219 -63
+ Misses 23916 23743 -173
+ Partials 1705 1697 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
| return buf.String(), nil | ||
| } | ||
|
|
||
| // // tableChecks returns a Markdown table with checks. |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Sentence should start with a capital letter (godot)
| return res | ||
| } | ||
|
|
||
| func validateTemplates(dir string, markdownT bool) { //nolint:cyclop |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:cyclop is unused for linter "cyclop" (nolintlint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14009
Link to the Feature Build: SUBMODULES-3960