Skip to content

Clang tidy does not work #2614

Closed
Closed
@cvvergara

Description

@cvvergara

While trying to use clang-tidy
Tidying headers:

$ clang-tidy -header-filter=./include include/a*/*.h* --  -I/home/path/to/repo/include -isystem /usr/include/postgresql/15/server -I/usr/include/boost/ -I/usr/include
2 errors generated.
Error while processing /home/path/to/repo/include/alphaShape/pgr_alphaShape.h.
2 errors generated.
Error while processing /home/path/to/repo/include/astar/astar.hpp.
/home/path/to/repo/include/alphaShape/pgr_alphaShape.h:34:2: error: This is C++ header file [clang-diagnostic-error]
#error This is C++ header file
 ^
/home/path/to/repo/include/alphaShape/pgr_alphaShape.h:37:10: error: 'vector' file not found [clang-diagnostic-error]
#include <vector>
         ^~~~~~~~
Found compiler error(s). 

The reason for this failure is that pgr_alphaShape.h should be an hpp file

Renaming of h to hpp is needed on files like this one

TODO

List of directories containing .h files that probably need to be changed to .hpp files

  • alphaShape
  • bellman_ford
  • breadthFirstSearch
  • c_common
  • c_types
  • chinese
  • circuits
  • coloring
  • components
  • contraction
  • cpp_common
  • dijkstra
  • dominator
  • drivers
  • lineGraph
  • max_flow
  • ordering
  • planar
  • spanningTree
  • transitiveClosure
  • trsp
  • tsp
  • visitors
  • vrp
  • withPoints
  • yen

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions