Skip to content

Standarizing output spanning tree functions #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ec8349c
[sql][prim] New _primv4 function with additional output column
cvvergara Jan 13, 2024
723d18f
[sql][prim] Adding pred column to results
cvvergara Jan 13, 2024
71dbd07
[sql][kruskal] New _pgr_kruskalv4 function with additional pred outpu…
cvvergara Jan 13, 2024
ac31387
[sql][kruskal] Adding pred column to results
cvvergara Jan 13, 2024
ab2a011
[src][kruskal] adding new _kruskalv4 C function
cvvergara Jan 13, 2024
f4a0029
[src][prim] adding new _primv4 C function
cvvergara Jan 13, 2024
fc31a56
[docqueries][prim] adjusting to new results
cvvergara Jan 13, 2024
2918e13
[docqueries][kruskal] adjusting to new results
cvvergara Jan 13, 2024
efbcc4f
[tap][spanningTree] tools for types_check standarizing
cvvergara Jan 13, 2024
29cc23e
[tap][kruskal] Error code based on version
cvvergara Jan 13, 2024
c9fcaab
[tap][prim] Error code based on version
cvvergara Jan 13, 2024
e45dcee
[doc] mst-dd-params -> spantree-params_
cvvergara Jan 13, 2024
a8e7d89
[doc][kruskal] adjusting documentation to new output column
cvvergara Jan 13, 2024
d17b65e
[doc][prim] adjusting documentation to new output column
cvvergara Jan 13, 2024
cf52a82
[doc] Adding release notes & NEWS
cvvergara Jan 13, 2024
2d44dc7
[kruskal][doc] adding migration guide
cvvergara Jan 13, 2024
4cecbe1
[prim][doc] adding migration guide
cvvergara Jan 13, 2024
3673907
[doc] fixing spelling mistakes
cvvergara Jan 13, 2024
1cfdc38
[sigs] signature file adding _pgr_kruskalv4 & _pgr_primv4
cvvergara Jan 16, 2024
8f4032e
[kruskal] fixing node -> pred
cvvergara Jan 16, 2024
99844f9
[doc] Updating queries for the migration guide
cvvergara Jan 16, 2024
4eb3573
[Upgrade] adjusting update scripts
cvvergara Jan 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,27 @@ To see all issues & pull requests closed by this release see the [Git closed
milestone for 3.7.0
](https://github.com/pgRouting/pgrouting/issues?utf8=%E2%9C%93&q=milestone%3A%22Release%203.7.0%22)

**Official functions changes**

* [#2605](https://github.com/pgRouting/pgrouting/pull/2605) Standarize
spanning tree functions output

* Functions:

* ``pgr_kruskalDD``
* ``pgr_kruskalDFS``
* ``pgr_kruskalBFS``
* ``pgr_primDD``
* ``pgr_primDFS``
* ``pgr_primBFS``


* Standarizing output columns to ``(seq, depth, start_vid, pred, node, edge, cost, agg_cost)``

* Added ``pred`` result columns.



**Code enhancement**

* [#2599](https://github.com/pgRouting/pgrouting/pull/2599) Driving distance
Expand Down
4 changes: 2 additions & 2 deletions doc/driving_distance/drivingDistance-category.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Calculate nodes that are within a distance.
Parameters
-------------------------------------------------------------------------------

.. mst-dd-params_start
.. spantree-params_start

.. list-table::
:width: 81
Expand Down Expand Up @@ -91,7 +91,7 @@ Where:

:ANY-NUMERIC: ``SMALLINT``, ``INTEGER``, ``BIGINT``, ``REAL``, ``FLOAT``

.. mst-dd-params_end
.. spantree-params_end

Inner Queries
-------------------------------------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions doc/driving_distance/pgr_drivingDistance.rst
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ Parameters
-------------------------------------------------------------------------------

.. include:: drivingDistance-category.rst
:start-after: mst-dd-params_start
:end-before: mst-dd-params_end
:start-after: spantree-params_start
:end-before: spantree-params_end

Optional parameters
...............................................................................
Expand Down
29 changes: 17 additions & 12 deletions doc/spanningTree/pgr_kruskalBFS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,15 @@ First Search ordering.

.. rubric:: Availability

* Version 3.0.0
:Version 3.7.0:

* New **Official** function
* Standarizing output columns to |result-spantree|

* Added ``pred`` result columns.

:Version 3.0.0:

* New **Official** function

Description
-------------------------------------------------------------------------------
Expand All @@ -52,7 +57,7 @@ Signatures
| pgr_kruskalBFS(`Edges SQL`_, **root vid**, [``max_depth``])
| pgr_kruskalBFS(`Edges SQL`_, **root vids**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

.. index::
single: kruskalBFS(Single vertex)
Expand All @@ -65,7 +70,7 @@ Single vertex

| pgr_kruskalBFS(`Edges SQL`_, **root vid**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree having as root vertex :math:`6`

Expand All @@ -84,7 +89,7 @@ Multiple vertices

| pgr_kruskalBFS(`Edges SQL`_, **root vids**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree starting on vertices :math:`\{9, 6\}` with
:math:`depth \leq 3`
Expand All @@ -96,9 +101,9 @@ Multiple vertices
Parameters
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-params_start
:end-before: mst-bfs-dfs-params_end
.. include:: drivingDistance-category.rst
:start-after: spantree-params_start
:end-before: spantree-params_end

BFS optional parameters
...............................................................................
Expand All @@ -111,7 +116,7 @@ Inner Queries
-------------------------------------------------------------------------------

Edges SQL
...............................................................................
..............................................................................

.. include:: pgRouting-concepts.rst
:start-after: basic_edges_sql_start
Expand All @@ -120,9 +125,9 @@ Edges SQL
Result columns
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-dd-result-columns-start
:end-before: mst-bfs-dfs-dd-result-columns-end
.. include:: drivingDistance-category.rst
:start-after: spantree-result-columns-start
:end-before: spantree-result-columns-end

See Also
-------------------------------------------------------------------------------
Expand Down
24 changes: 15 additions & 9 deletions doc/spanningTree/pgr_kruskalDD.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@

.. rubric:: Availability

* Version 3.0.0
:Version 3.7.0:

* Standarizing output columns to |result-spantree|

* Added ``pred`` result columns.

:Version 3.0.0:

* New **Official** function

Expand Down Expand Up @@ -55,7 +61,7 @@ Signatures
| pgr_kruskalDD(`Edges SQL`_, **root vid**, **distance**)
| pgr_kruskalDD(`Edges SQL`_, **root vids**, **distance**)

| Returns set of |result-bfs|
| Returns set of |result-spantree|

.. index::
single: kruskalDD(Single vertex)
Expand All @@ -68,7 +74,7 @@ Single vertex

| pgr_kruskalDD(`Edges SQL`_, **root vid**, **distance**)

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree starting on vertex :math:`6` with
:math:`distance \leq 3.5`
Expand All @@ -88,7 +94,7 @@ Multiple vertices

| pgr_kruskalDD(`Edges SQL`_, **root vids**, **distance**)

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree starting on vertices :math:`\{9, 6\}` with
:math:`distance \leq 3.5`
Expand All @@ -101,8 +107,8 @@ Parameters
-------------------------------------------------------------------------------

.. include:: drivingDistance-category.rst
:start-after: mst-dd-params_start
:end-before: mst-dd-params_end
:start-after: spantree-params_start
:end-before: spantree-params_end

Inner Queries
-------------------------------------------------------------------------------
Expand All @@ -117,9 +123,9 @@ Edges SQL
Result columns
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-dd-result-columns-start
:end-before: mst-bfs-dfs-dd-result-columns-end
.. include:: drivingDistance-category.rst
:start-after: spantree-result-columns-start
:end-before: spantree-result-columns-end

See Also
-------------------------------------------------------------------------------
Expand Down
28 changes: 17 additions & 11 deletions doc/spanningTree/pgr_kruskalDFS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ First Search ordering.

.. rubric:: Availability

* Version 3.0.0
:Version 3.7.0:

* Standarizing output columns to |result-spantree|

* Added ``pred`` result columns.

:Version 3.0.0:

* New **Official** function

Expand Down Expand Up @@ -52,7 +58,7 @@ Signatures
| pgr_kruskalDFS(`Edges SQL`_, **root vid**, [``max_depth``])
| pgr_kruskalDFS(`Edges SQL`_, **root vids**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

.. index::
single: kruskalDFS(Single vertex)
Expand All @@ -65,7 +71,7 @@ Single vertex

| pgr_kruskalDFS(`Edges SQL`_, **root vid**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree having as root vertex :math:`6`

Expand All @@ -84,7 +90,7 @@ Multiple vertices

| pgr_kruskalDFS(`Edges SQL`_, **root vids**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree starting on vertices :math:`\{9, 6\}` with
:math:`depth \leq 3`
Expand All @@ -96,9 +102,9 @@ Multiple vertices
Parameters
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-params_start
:end-before: mst-bfs-dfs-params_end
.. include:: drivingDistance-category.rst
:start-after: spantree-params_start
:end-before: spantree-params_end

DFS optional parameters
...............................................................................
Expand All @@ -111,7 +117,7 @@ Inner Queries
-------------------------------------------------------------------------------

Edges SQL
...............................................................................
..............................................................................

.. include:: pgRouting-concepts.rst
:start-after: basic_edges_sql_start
Expand All @@ -120,9 +126,9 @@ Edges SQL
Result columns
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-dd-result-columns-start
:end-before: mst-bfs-dfs-dd-result-columns-end
.. include:: drivingDistance-category.rst
:start-after: spantree-result-columns-start
:end-before: spantree-result-columns-end

See Also
-------------------------------------------------------------------------------
Expand Down
37 changes: 21 additions & 16 deletions doc/spanningTree/pgr_primBFS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,21 @@ Search ordering.

.. rubric:: Availability

* Version 3.0.0
:Version 3.7.0:

* New **Official** function
* Standarizing output columns to |result-spantree|

* Added ``pred`` result columns.

:Version 3.0.0:

* New **Official** function

Description
-------------------------------------------------------------------------------

Visits and extracts the nodes information in Breath First Search ordering
of the Minimum Spanning Tree created with Prims's algorithm.
of the Minimum Spanning Tree created using Prims's algorithm.

**The main Characteristics are:**

Expand All @@ -52,7 +57,7 @@ Signatures
| pgr_primBFS(`Edges SQL`_, **root vid**, [``max_depth``])
| pgr_primBFS(`Edges SQL`_, **root vids**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

.. index::
single: primBFS(Single vertex)
Expand All @@ -65,7 +70,7 @@ Single vertex

| pgr_primBFS(`Edges SQL`_, **root vid**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree having as root vertex :math:`6`

Expand All @@ -84,7 +89,7 @@ Multiple vertices

| pgr_primBFS(`Edges SQL`_, **root vids**, [``max_depth``])

| Returns set of |result-bfs|
| Returns set of |result-spantree|

:Example: The Minimum Spanning Tree starting on vertices :math:`\{9, 6\}` with
:math:`depth \leq 3`
Expand All @@ -96,9 +101,9 @@ Multiple vertices
Parameters
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-params_start
:end-before: mst-bfs-dfs-params_end
.. include:: drivingDistance-category.rst
:start-after: spantree-params_start
:end-before: spantree-params_end

BFS optional parameters
...............................................................................
Expand All @@ -111,25 +116,25 @@ Inner Queries
-------------------------------------------------------------------------------

Edges SQL
...............................................................................
..............................................................................

.. include:: pgRouting-concepts.rst
:start-after: basic_edges_sql_start
:end-before: basic_edges_sql_end
:start-after: basic_edges_sql_start
:end-before: basic_edges_sql_end

Result columns
-------------------------------------------------------------------------------

.. include:: BFS-category.rst
:start-after: mst-bfs-dfs-dd-result-columns-start
:end-before: mst-bfs-dfs-dd-result-columns-end
.. include:: drivingDistance-category.rst
:start-after: spantree-result-columns-start
:end-before: spantree-result-columns-end

See Also
-------------------------------------------------------------------------------

* :doc:`spanningTree-family`
* :doc:`prim-family`
* The queries use the :doc:`sampledata` network.
* :doc:`sampledata`
* `Boost: Prim's algorithm documentation
<https://www.boost.org/libs/graph/doc/prim_minimum_spanning_tree.html>`__
* `Wikipedia: Prim's algorithm
Expand Down
Loading